Add compatibility with Python 3.10+ and Django 3+#54
Open
nikitagrygoriev wants to merge 5 commits intopython-babel:masterfrom
Open
Add compatibility with Python 3.10+ and Django 3+#54nikitagrygoriev wants to merge 5 commits intopython-babel:masterfrom
nikitagrygoriev wants to merge 5 commits intopython-babel:masterfrom
Conversation
mrunge
reviewed
Feb 1, 2022
| maintainer='Thomas Grainger', | ||
| maintainer_email='django-babel@graingert.co.uk', | ||
| url='https://github.com/python-babel/django-babel/', | ||
| maintainer='Nikita Grygoriev', |
Contributor
There was a problem hiding this comment.
You are replacing the maintainer etc. here. This also changes the URL, not sure that is intended?
mrunge
requested changes
Feb 1, 2022
Contributor
mrunge
left a comment
mrunge
left a comment
There was a problem hiding this comment.
Thank you for your PR!
This project is more or less unmaintained and as noted in #51 the forked project enmerkar is a replacement for django-babel.
Other than that (and if the requested changes are addressed), I'd merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.